[
https://issues.apache.org/jira/browse/NIFI-12021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763108#comment-17763108
]
Daniel Stieglitz edited comment on NIFI-12021 at 9/8/23 2:21 PM:
-----------------------------------------------------------------
[~exceptionfactory] Thanks for the clarification. I had another question. In
TlsHelperGroovyTest.groovy
There is the following block of code:
{code:java}
@BeforeAll
static void setProvider() {
System.setProperty("org.bouncycastle.rsa.allow_unsafe_mod","true")
Security.addProvider(new BouncyCastleProvider())
BCRSAPublicKey badPublicKey = new BCRSAPublicKey(new
RSAKeyParameters(false, new BigInteger("3", 10), new BigInteger("1", 10)))
}{code}
First of all in Java the instantiation of BCRSAPublicKey will not work as its
constructor has package private scope. Second of all the assignment to the
badPublicKey variable is never used. Third of all I noticed that the unit
tests in this file work whether that code is there or whether it is commented
out. So can I leave this off when porting these tests to the Java test version
or is it somehow needed to demonstrate something else?
was (Author: JIRAUSER294662):
[~exceptionfactory] Thanks for the clarification. I had another question. In
TlsHelperGroovyTest.groovy
There is the following block of code:
{code:java}
@BeforeAll
static void setProvider() {
System.setProperty("org.bouncycastle.rsa.allow_unsafe_mod","true")
Security.addProvider(new BouncyCastleProvider())
BCRSAPublicKey badPublicKey = new BCRSAPublicKey(new
RSAKeyParameters(false, new BigInteger("3", 10), new BigInteger("1", 10)))
}{code}
First of all in Java the instantiation of BCRSAPublicKey will not work as its
constructor has package private scope. Second of all the assignment to the
badPublicKey variable is never used. Third of all I noticed that the unit
tests in this file work whether that code is there or whether it is commented
out. So can I leave this off when porting these tests to the Java test version
or is somehow needed?
> Convert Groovy unit tests in nifi-toolkit-tls to Java
> -----------------------------------------------------
>
> Key: NIFI-12021
> URL: https://issues.apache.org/jira/browse/NIFI-12021
> Project: Apache NiFi
> Issue Type: Sub-task
> Reporter: Daniel Stieglitz
> Assignee: Daniel Stieglitz
> Priority: Minor
>
> The two test to refactor are
> {code:java}
> TlsToolkitStandaloneGroovyTest.groovy
> TlsHelperGroovyTest.groovy{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
