fgerlits commented on code in PR #1652:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1652#discussion_r1319983450
##########
docker/test/integration/features/steps/steps.py:
##########
Review Comment:
Is the "an MQTT broker is deployed in correspondence with the PublishMQTT"
step correct? Should it be removed and the "an MQTT broker is set up in
correspondence with the PublishMQTT" step used instead?
##########
docker/test/integration/features/steps/steps.py:
##########
@@ -428,6 +428,7 @@ def step_impl(context):
@given("an MQTT broker is set up in correspondence with the PublishMQTT and
ConsumeMQTT")
def step_impl(context):
context.test.acquire_container(context=context, name="mqtt-broker",
engine="mqtt-broker")
+ context.test.start('mqtt-broker')
Review Comment:
We already have a "the MQTT broker is started" step for this, which is used
in the `Retained message` scenario outline.
It would be better to do this the same way in all scenarios: either add
"When/And the MQTT broker is started" to all scenarios and remove the `start`
from here, or remove the "the MQTT broker is started" step completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
