martinzink commented on code in PR #1634:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1634#discussion_r1320119880
##########
libminifi/src/core/logging/Logger.cpp:
##########
@@ -100,7 +100,7 @@ bool Logger::should_log(const LOG_LEVEL &level) {
void Logger::log_string(LOG_LEVEL level, std::string str) {
switch (level) {
case critical:
- log_warn(str.c_str());
+ log_critical(str.c_str());
Review Comment:
yeah, I dont think we use it anywhere but if in the future we encounter
something that would warrant a critical log we sure as hell wouldnt want to
miss it by accident
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
