adamdebreceni commented on code in PR #1640:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1640#discussion_r1321364832
##########
libminifi/include/core/ContentRepository.h:
##########
@@ -30,13 +31,23 @@
#include "ContentSession.h"
#include "core/RepositoryMetricsSource.h"
#include "core/Core.h"
+#include "core/StreamAppendLock.h"
namespace org::apache::nifi::minifi::core {
/**
* Content repository definition that extends StreamManager.
*/
class ContentRepository : public core::CoreComponent, public
StreamManager<minifi::ResourceClaim>, public
utils::EnableSharedFromThis<ContentRepository>, public
core::RepositoryMetricsSource {
+ class ContentStreamAppendLock : public StreamAppendLock {
Review Comment:
it reflects the class hierarchy of ContentRepository and StreamManager,
since StreamManager generates the write stream (which are possibly append
streams) locking for append should appear at that level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
