pvillard31 commented on code in PR #7686:
URL: https://github.com/apache/nifi/pull/7686#discussion_r1327105556
##########
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/csv/CSVRecordSetWriter.java:
##########
@@ -43,9 +45,31 @@
+ "corresponding to the record fields.")
public class CSVRecordSetWriter extends DateTimeTextRecordSetWriter implements
RecordSetWriterFactory {
+ // CSV writer implementations
+ public static final AllowableValue APACHE_COMMONS_CSV = new
AllowableValue("commons-csv", "Apache Commons CSV",
+ "The CSV writer implementation from the Apache Commons CSV
library.");
+
+ public static final AllowableValue FAST_CSV = new
AllowableValue("fast-csv", "FastCSV",
+ "The CSV writer implementation from the FastCSV library. NOTE:
This writer only officially supports RFC-4180, so it recommended to "
+ + "set the 'CSV Format' property to 'RFC 4180'. It does
handle some non-compliant CSV data, for that case set the 'CSV Format' property
to "
+ + "'CUSTOM' and the other custom format properties (such
as 'Trim Fields', 'Trim double quote', etc.) as appropriate. Be aware that this
"
+ + "may cause errors if FastCSV doesn't handle the property
settings correctly (such as 'Ignore Header'), but otherwise may process the
output as expected even "
Review Comment:
I think it should be slightly reworded as 'Ignore Header' does not exist on
the Writer side. No?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
