[GitHub] [nifi] markobean commented on pull request #7591: NIFI-11874 update Process Group configuration layout in the UI

[via GitHub]

markobean commented on PR #7591:
URL: https://github.com/apache/nifi/pull/7591#issuecomment-1721421829

   > @markobean Thanks for the PR! Utilizing the extra real estate of the 
Configuration dialog is a great idea. I have a couple of suggestions:
   > 
   > <img alt="Screenshot 2023-09-13 at 2 59 50 PM" width="1666" 
src="https://user-images.githubusercontent.com/56892372/267799683-1a894a71-ea68-4d53-be24-e0c0d48814c1.png";>
   > * Now that we have more than one column, the `Apply Recursively` checkbox 
looks out of place. Furthermore, if the browser width reduces, then the 
checkbox and label get pushed into the Parameter Context menu. I suggest moving 
the checkbox and label to the right of the `Apply` button and change the label 
to: `Apply Parameter Context recursively`, to be more clear of the action.
   > 
   > <img alt="Screenshot 2023-09-13 at 3 00 04 PM" width="495" 
src="https://user-images.githubusercontent.com/56892372/267800273-613bd567-c257-4cd2-b30d-6c395e352792.png";>
   > * Since we have still have a good amount of empty space remaining in the 
General tab, I suggest to remove the Comments tab and add the Comments 
`textarea` as a third column in the General tab. This way we can also keep the 
`Apply` click action in one place.
   > 
   > Thoughts?
   
   Thanks for the feedback @mtien-apache! I am away for the next 10 days, but 
will get to this when I return.
   
   As far as the comments tab, I like it being separate to be consistent with 
other components. It also leaves room for growth for the main General tab. It 
has seen the addition of numerous properties, and I feel this may continue over 
time.
   
   Thanks,
   Mark


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org