exceptionfactory commented on code in PR #7744: URL: https://github.com/apache/nifi/pull/7744#discussion_r1327968092
########## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/bootstrap.conf: ########## @@ -90,6 +85,13 @@ java.arg.17=-Dzookeeper.admin.enableServer=false # org.apache.jasper.servlet.JasperLoader,org.jvnet.hk2.internal.DelegatingClassLoader,org.apache.nifi.nar.NarClassLoader # End of Java Agent config for native library loading. +# The following entry is needed in Java 21 because some libraries invoke +# reflective calls that Java no longer considers allowed by default. +# https://docs.oracle.com/en/java/javase/16/migrate/migrating-jdk-8-later-jdk-releases.html#GUID-7BB28E4D-99B3-4078-BDC4-FC24180CE82B +# This may need to be modified if additional reflective access is needed by certain libraries +# This is only known to be needed for the Hive3 processors as of now. +java.arg.20=--add-opens=java.base/java.net=ALL-UNNAMED Review Comment: Although this is an unfortunate requirement for Hive 3, the comment is helpful. Hopefully we can remove this in the future with newer Hive versions. ########## nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/pom.xml: ########## @@ -412,6 +412,15 @@ </dependencies> <build> <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-surefire-plugin</artifactId> + <configuration> + <environmentVariables> + <JDK_JAVA_OPTIONS>--add-opens java.base/java.net=ALL-UNNAMED</JDK_JAVA_OPTIONS> Review Comment: A comment on the reason for this inclusion avoid be helpful, mentioning the offending Hive class. ########## .github/workflows/ci-workflow.yml: ########## @@ -97,11 +96,11 @@ jobs: ~/.m2/repository # Cache Maven modules using a cache key different from setup-java steps key: ${{ runner.os }}-maven-static-analysis-${{ hashFiles('**/pom.xml') }} - - name: Set up Java 17 + - name: Set up Java 21 uses: actions/setup-java@v3 with: distribution: 'zulu' - java-version: '17' + java-version: '21-ea' Review Comment: We should avoid switching an Early Access build version and wait until the official release version is ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
