levilentz commented on PR #7677: URL: https://github.com/apache/nifi/pull/7677#issuecomment-1728912518
@mattyb149 @joewitt @exceptionfactory @MikeThomsen -- ready for another review. I have done the following: 1. Updated documentation to better show how to use this component 2. Addressed all outstanding PR concerns on the code (need some guidance on the licensing stance) 3. Build out a unit test showing the gremlin bytecode functionality I was not able to get test containers working with JG, so I might still tinker with that to see if I can get the whole test suite working. For that integration test utilizing gremlin bytecode that I have built out, it needs to load a gremlin serializer, which requires setting the custom jar. I have one that does that, but it is ~15MB in size, so I dont think it is wise to add it to the git history. Do you have any guidance on how best to create that jar on the fly for the test? Or should I just put some documentation on how to download the jar to run the test? It just simply is the standard serializers available in the gremlin driver package, but they are not loaded by default in the controller. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
