fgerlits commented on code in PR #1665:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1665#discussion_r1334521692
##########
libminifi/include/core/PropertyDefinition.h:
##########
@@ -39,7 +39,7 @@ struct PropertyDefinition {
std::array<std::string_view, NumDependentProperties> dependent_properties;
std::array<std::pair<std::string_view, std::string_view>,
NumExclusiveOfProperties> exclusive_of_properties;
std::optional<std::string_view> default_value;
- gsl::not_null<const PropertyType*> type =
gsl::make_not_null(&StandardPropertyTypes::VALID_TYPE);
+ gsl::not_null<const PropertyType*> type = gsl::make_not_null<const
PropertyType*>(&StandardPropertyTypes::VALID_TYPE);
Review Comment:
The deduced argument is `const AlwaysValidPropertyType*`, and Visual Studio
complained that it can't decide whether to use a converting copy constructor or
a conversion operator. I have changed the initialization to use `{}` instead
of `=` in 820e4ae455fc335cdd0594bf9495cc351c48e520, and it seems happy with
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
