Hexoplon opened a new pull request, #7787: URL: https://github.com/apache/nifi/pull/7787
<!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary [NIFI-12122](https://issues.apache.org/jira/browse/NIFI-12122) When creating a parameter context and adding a description it gets persisted to the flow.json.gz flow definition. If NiFi is shut down, and then restarted, the parameter context is loaded by the controller and FlowManager, but the description is not loaded. The flow is then saved to disk, loosing the parameter context description in the process. This PR solves that by modifying the FlowManager interface and adding a `description` parameter to the createParameterContext method. Then in AbstractFlowManager, a `.setDescription()` step is added, to add the passed description value to the created parameter context. Also added a test to verify that the parameter context that is imported to the flow manager contains a description if the flow.xml.gz flow file had a description for it. The rest of the edits are to make existing tests and function calls compatible with the updated FlowManager change. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### Licensing ~~- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)~~ ~~- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files~~ ### Documentation ~~- [ ] Documentation formatting appears as expected in rendered files~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
