joewitt commented on PR #7750: URL: https://github.com/apache/nifi/pull/7750#issuecomment-1734105437
Full clean build with contrib check good. And Github CI looking great. Reviewed each changed file all looks good. Some of the changes in files seemed massive due to perhaps whitespace but doesn't seem worth delaying this further. Ran a series of tests using system properties. Environment variables. Parameter contexts. Looking each up either directly in the processor properties of UpdateAttribute or via parameter context lookup. All worked as expected. Great work Pierre. This is a massive PR. But dont want to delay it further as it will impact many things going into 2.x from here out. This one is so expansive it likely starts to really make the break betweeen 2.x and 1.x. Other notable changing the scope from VARIABLE to ENVIRONMENT will surely make 1.x processors not run on 2.x but I think we're likely well into needing people to rebuild for 2.x anyway a thing. +1 merging to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
