tanmaya-panda1 commented on code in PR #7624:
URL: https://github.com/apache/nifi/pull/7624#discussion_r1336374183
##########
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/services/azure/data/explorer/StandardKustoQueryService.java:
##########
@@ -159,10 +162,7 @@ private ConnectionStringBuilder
getConnectionStringBuilder(final ConfigurationCo
builder =
ConnectionStringBuilder.createWithAadApplicationCredentials(clusterUrl,
clientId, applicationKey, tenantId);
}
- final String vendor = System.getProperty("java.vendor");
- final String version = System.getProperty("java.version");
-
- builder.setConnectorDetails(vendor, version, null, null, false, null);
+ builder.setConnectorDetails("Kusto.Nifi.Source",
StandardKustoQueryService.class.getPackage().getImplementationVersion(), null,
null, false, null, NIFI_SOURCE);
Review Comment:
Yes this change is necessary since connector details/identifier along with
version information is required for identification of request in ADX(Azure Data
Explorer) cluster for debugging and tracking purpose. This is a standard across
all the connectors we have implemented for Azure Data Explorer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]