lordgamez commented on code in PR #1635:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1635#discussion_r1336905243
##########
.github/workflows/ci.yml:
##########
@@ -116,13 +116,64 @@ jobs:
if: always()
with:
path: ~/AppData/Local/Mozilla/sccache/cache
- key: ${{ runner.os }}-sccache-${{ github.ref }}-${{ github.sha }}
+ key: ${{ runner.os }}-2022-sccache-${{ github.ref }}-${{ github.sha
}}
- name: test
run: cd ..\b && ctest --timeout 300 --parallel %NUMBER_OF_PROCESSORS%
-C Release --output-on-failure
shell: cmd
- name: linter
run: cd ..\b && cmake --build . --target linter --config Release -j 8
shell: cmd
+ windows_VS2019:
Review Comment:
Should we run both VS2019 and VS2022 jobs for every commit? We could extract
one of them to a separate workflow like the gcc13 compatiblity job. We could
create a cronjob for that (and for the gcc13 and python compatibility jobs as
well while we are at it) and run them once a week for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
