[
https://issues.apache.org/jira/browse/NIFI-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732168#comment-15732168
]
ASF GitHub Bot commented on NIFI-3165:
--------------------------------------
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1308
Reviewing...
> RemoteProcessGroupPort change doesn't update revision immediately
> -----------------------------------------------------------------
>
> Key: NIFI-3165
> URL: https://issues.apache.org/jira/browse/NIFI-3165
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core UI
> Affects Versions: 1.0.0
> Reporter: Koji Kawamura
> Priority: Trivial
>
> In nf-remote-process-group-ports.js there're two TODO comments remaining:
> {code}
> // TODO - update the revision
> // nf.Client.setRevision(response.revision);
> {code}
> [initRemotePortConfigurationDialog|https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-remote-process-group-ports.js#L71]:
> executed when a port configuration is updated by clicking the "Apply" button
> on "Configure Remote Port" window.
> [createPortOption|https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-remote-process-group-ports.js#L301]:
> executed when a port is enabled or disabled by clicking the toggle button on
> "Remote Process Group Ports" window.
> Both operation send a PUT request to
> /nifi-api/remote-process-groups/<rpg-id>/input-ports/<port-id> (or
> output-ports), using RPG's revision.
> But as written with the TODO comments, these functions don't update revision
> to the one returned as a response of the PUT requests.
> This doesn't cause any issues because NiFi REST API allows update requests
> even its revision is not the latest, as long as the last update was made by
> the same user.
> Also, NiFi UI refreshes whole data flow periodically, and update RPG's
> revision automatically.
> However, the TODO should be addressed, by updating revision in cached object
> in NiFi UI immediately after those PUT requests, using the response data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
