mattyb149 commented on code in PR #7677:
URL: https://github.com/apache/nifi/pull/7677#discussion_r1340440524
##########
nifi-nar-bundles/nifi-graph-bundle/nifi-other-graph-services/pom.xml:
##########
@@ -38,6 +38,11 @@
<version>2.0.0-SNAPSHOT</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-graph-processors</artifactId>
Review Comment:
What's this dependency used for? If it's only for the link in the
documentation I say remove both. Services shouldn't depend on the components
that use them. If we need to refactor things out to an API that's fine.
##########
nifi-nar-bundles/nifi-graph-bundle/nifi-other-graph-services/src/main/java/org/apache/nifi/graph/TinkerpopClientService.java:
##########
@@ -235,9 +234,10 @@ public class TinkerpopClientService extends
AbstractControllerService implements
SSL_CONTEXT_SERVICE
));
- private ScriptEngineManager MANAGER = new ScriptEngineManager();
- private ScriptEngine engine;
- private Map<String, CompiledScript> compiledCode;
+// private ScriptEngineManager MANAGER = new ScriptEngineManager();
Review Comment:
Please delete dead code
##########
nifi-nar-bundles/nifi-graph-bundle/nifi-other-graph-services/src/main/java/org/apache/nifi/graph/TinkerpopClientService.java:
##########
@@ -140,7 +139,7 @@ public class TinkerpopClientService extends
AbstractControllerService implements
.required(true)
.defaultValue("/gremlin")
.addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
Review Comment:
Is it possible to configure a Gremlin server such that the path is empty? If
so we should replace this validator with either Validators.TRUE or something
like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
