markap14 commented on code in PR #7661:
URL: https://github.com/apache/nifi/pull/7661#discussion_r1340472803
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/audit/PortAuditor.java:
##########
@@ -93,14 +91,8 @@ public Port updatePortAdvice(ProceedingJoinPoint
proceedingJoinPoint, PortDTO po
final int maxConcurrentTasks = port.getMaxConcurrentTasks();
final Set<String> existingUsers = new HashSet<>();
- final Set<String> existingGroups = new HashSet<>();
boolean isPublicPort = false;
Review Comment:
It looks like `isPublicPort` will always be false here, as you've removed
the `if (port instanceof PublicPort) {... }`. I think we need to instead set
`boolean isPublicPort = port instanceof PublicPort;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
