exceptionfactory commented on code in PR #7740:
URL: https://github.com/apache/nifi/pull/7740#discussion_r1341690686
##########
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/eventhub/utils/AzureEventHubUtils.java:
##########
@@ -103,4 +111,42 @@ public static Map<String, String>
getApplicationProperties(final Map<String,Obje
return properties;
}
+
+ /**
+ * Creates the {@link ProxyOptions proxy options}.
+ *
+ * @param propertyContext to supply Proxy configurations
+ * @return {@link ProxyOptions proxy options}, null if Proxy is not set
+ */
+ public static ProxyOptions getProxyOptions(final PropertyContext
propertyContext) {
Review Comment:
Instead of returning a nullable `ProxyOptions`, what do you think about
returning it in an `Optional` wrapper? That would indicate the contract more
clearly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
