Github user bbende commented on the issue:

    https://github.com/apache/nifi/pull/1307
  
    @randerzander I tested this out and I think we have to move the addition of 
the attributes to inside the loop where the flow files are being created. If we 
do it after the loop, then session.transfer has already been called on each 
flow file and we can no longer update it, it was causing an error when I tested 
it out.
    
    I made a couple of updates and have a working version in the latest commit 
here:
    https://github.com/bbende/nifi/commits/NIFI-2585
    
    The changes I made were the following:
    1) Move the attributes into the while loop in AbstractFlowFileServerProtocol
    2) Added the same attributes in StandardRemoteGroupPort for pull-based 
site-to-site
    3) Used "s2s." prefix for the attribute names (I know I suggest "remote." 
in the JIRA, but I started thinking it wasn't descriptive enough).
    
    I tested this out with two NiFi instances on my laptop doing push and pull 
based s2s and it appears to be working correctly. 
    
    If you agree with the changes you could put my commit into your branch and 
update this PR, or if you want to close this I can submit my branch with both 
our commits as a new PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to