exceptionfactory commented on code in PR #7832:
URL: https://github.com/apache/nifi/pull/7832#discussion_r1344519865
##########
nifi-external/nifi-kafka-connect/nifi-kafka-connector-tests/src/test/java/org/apache/nifi/kafka/connect/ITStatelessKafkaConnectorUtil.java:
##########
Review Comment:
Although this exercise the issue, we should avoid adding new integration
tests unless they provide significant value. Integration tests outside of
`nifi-system-test-suite` are not executed in automated workflows and canmore
stale when refactoring.
##########
nifi-external/nifi-kafka-connect/nifi-kafka-connector/src/main/java/org/apache/nifi/kafka/connect/StatelessKafkaConnectorUtil.java:
##########
@@ -269,4 +275,53 @@ private static File detectNarDirectory() {
logger.info("Detected NAR Directory to be {}",
narDirectory.getAbsolutePath());
return narDirectory;
}
+
+ private static void checkWorkingDirectoryIntegrity(final File
workingDirectory) {
+ purgeIncompleteUnpackedNars(new File(new File(workingDirectory,
"nar"), "extensions"));
Review Comment:
It looks like purge method could be abstracted to a separate utility, which
would make it much easier to unit test.
##########
nifi-external/nifi-kafka-connect/nifi-kafka-connector-tests/pom.xml:
##########
@@ -61,10 +61,22 @@
<version>2.0.0-SNAPSHOT</version>
<type>nar</type>
</dependency>
+ <dependency>
+ <groupId>commons-io</groupId>
+ <artifactId>commons-io</artifactId>
+ <version>2.13.0</version>
Review Comment:
This version number should be removed because it is set in the root Maven
configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
