markap14 commented on code in PR #7836:
URL: https://github.com/apache/nifi/pull/7836#discussion_r1345916108
##########
nifi-nar-bundles/nifi-extension-utils/nifi-prometheus-utils/pom.xml:
##########
@@ -53,6 +53,11 @@
<artifactId>nifi-metrics</artifactId>
<version>2.0.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-framework-api</artifactId>
+ <version>2.0.0-SNAPSHOT</version>
+ </dependency>
Review Comment:
We should not have extensions / utils depending on nifi-framework-api. That
is solely for use by the nifi framework and can change at any point in time.
I would be okay with moving the `StorageUsage` class to nifi-api and adding
methods to `EventAccess` to expose the `StorageUsage` for the particular
repositories, but we should not be exposing things like SystemDiagnostics to
extensions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
