szaszm commented on code in PR #1658:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1658#discussion_r1346999182
##########
extensions/libarchive/tests/ManipulateArchiveTests.cpp:
##########
@@ -31,13 +31,13 @@
#include "ManipulateArchive.h"
#include "FocusArchiveEntry.h"
#include "UnfocusArchiveEntry.h"
-#include "../unit/ProvenanceTestHelper.h"
+#include "unit/ProvenanceTestHelper.h"
#include "repository/VolatileContentRepository.h"
-const char TEST_ARCHIVE_NAME[] = "manipulate_test_archive.tar";
+const char* TEST_ARCHIVE_NAME = "manipulate_test_archive.tar";
Review Comment:
```suggestion
constexpr const char* TEST_ARCHIVE_NAME = "manipulate_test_archive.tar";
```
##########
extensions/libarchive/tests/ManipulateArchiveTests.cpp:
##########
@@ -31,13 +31,13 @@
#include "ManipulateArchive.h"
#include "FocusArchiveEntry.h"
#include "UnfocusArchiveEntry.h"
-#include "../unit/ProvenanceTestHelper.h"
+#include "unit/ProvenanceTestHelper.h"
#include "repository/VolatileContentRepository.h"
-const char TEST_ARCHIVE_NAME[] = "manipulate_test_archive.tar";
+const char* TEST_ARCHIVE_NAME = "manipulate_test_archive.tar";
const int NUM_FILES = 3;
-const char* FILE_NAMES[NUM_FILES] = {"first", "middle", "last"};
-const char* FILE_CONTENT[NUM_FILES] = {"Test file 1\n", "Test file 2\n", "Test
file 3\n"};
+std::array<const char*, NUM_FILES> FILE_NAMES = {"first", "middle", "last"};
+std::array<const char*, NUM_FILES> FILE_CONTENT = {"Test file 1\n", "Test file
2\n", "Test file 3\n"};
Review Comment:
```suggestion
constexpr std::array<const char*, NUM_FILES> FILE_NAMES = {"first",
"middle", "last"};
constexpr std::array<const char*, NUM_FILES> FILE_CONTENT = {"Test file
1\n", "Test file 2\n", "Test file 3\n"};
```
##########
extensions/libarchive/tests/ManipulateArchiveTests.cpp:
##########
@@ -31,13 +31,13 @@
#include "ManipulateArchive.h"
#include "FocusArchiveEntry.h"
#include "UnfocusArchiveEntry.h"
-#include "../unit/ProvenanceTestHelper.h"
+#include "unit/ProvenanceTestHelper.h"
#include "repository/VolatileContentRepository.h"
-const char TEST_ARCHIVE_NAME[] = "manipulate_test_archive.tar";
+const char* TEST_ARCHIVE_NAME = "manipulate_test_archive.tar";
const int NUM_FILES = 3;
-const char* FILE_NAMES[NUM_FILES] = {"first", "middle", "last"};
-const char* FILE_CONTENT[NUM_FILES] = {"Test file 1\n", "Test file 2\n", "Test
file 3\n"};
+std::array<const char*, NUM_FILES> FILE_NAMES = {"first", "middle", "last"};
+std::array<const char*, NUM_FILES> FILE_CONTENT = {"Test file 1\n", "Test file
2\n", "Test file 3\n"};
Review Comment:
These should be top-level `const` IMO, or `constexpr` if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
