exceptionfactory commented on code in PR #7823:
URL: https://github.com/apache/nifi/pull/7823#discussion_r1348676643


##########
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/AbstractJsonRowRecordReader.java:
##########
@@ -51,16 +53,31 @@
 import java.util.function.Supplier;
 
 public abstract class AbstractJsonRowRecordReader implements RecordReader {
+    static final PropertyDescriptor MAX_STRING_LENGTH = new 
PropertyDescriptor.Builder()
+            .name("max-string-length")

Review Comment:
   That's a good point. Although it will take some effort, 
[NIFI-12139](https://issues.apache.org/jira/browse/NIFI-12139) will allow 
renaming properties without impacting existing flows, providing the opportunity 
to bring a standard approach to all extensions. As the changes in SplitJson are 
not yet released, we could also make adjustments there sooner.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to