Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/1312
@kedarchitale I've done quick scan through the contrib so not a thorough
evaluation. But I want to immediately say thank you for what is quite
obviously a very thoughtful and detailed contribution. You appear to have been
very thoughtful about license and notice and following convention around which
is extremely appreciated. Nice!
I also noticed you provided excellent documentation for the processor.
Instead of that being expressed in the readme file could you take a look at
some of the example processors that take advantage of the 'additionalDetails'
which means this wonderful information becomes part of the automated
documentation and available to the user through the application?
I noticed there was a properties file in the src/main/resources. I haven't
looked into how that ties in but if this is something you'll want the user to
be able to edit perhaps we can consider some alternative approaches. One
challenge with properties files is that if it is meant to be user editable then
it can become cluster unfriendly. So perhaps those things could be expressed
as processor properties instead or even as a single processor property. Not
sure and perhaps you've already thought through that. Just wanted to mention
it.
Anyway - great stuff and thanks for contributing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
