szaszm commented on code in PR #1676:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1676#discussion_r1354588041
##########
libminifi/include/core/logging/internal/LogCompressorSink.h:
##########
@@ -54,7 +48,7 @@ class LogCompressorSink : public
spdlog::sinks::base_sink<std::mutex> {
void flush_() override;
public:
- explicit LogCompressorSink(LogQueueSize cache_size, LogQueueSize
compressed_size, std::shared_ptr<logging::Logger> logger);
+ LogCompressorSink(LogQueueSize cache_size, LogQueueSize compressed_size,
const std::shared_ptr<logging::Logger>& logger);
Review Comment:
Makes sense. It's fine as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
