lordgamez commented on code in PR #1674:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1674#discussion_r1355279283


##########
docker/test/integration/features/MiNiFi_integration_test_driver.py:
##########
@@ -244,11 +246,21 @@ def check_for_num_files_generated(self, num_flowfiles, 
timeout_seconds):
         
output_validator.set_output_dir(self.file_system_observer.get_output_dir())
         self.__check_output(timeout_seconds, output_validator, max(1, 
num_flowfiles))
 
-    def check_for_num_file_range_generated(self, min_files, max_files, 
wait_time_in_seconds):
+    def check_for_num_file_range_generated_after_timeout(self, min_files: int, 
max_files: int, wait_time_in_seconds: int):
         output_validator = NumFileRangeValidator(min_files, max_files)
         
output_validator.set_output_dir(self.file_system_observer.get_output_dir())
         self.__check_output_after_time_period(wait_time_in_seconds, 
output_validator)
 
+    def check_for_num_file_range_generated(self, min_files: int, max_files: 
int, wait_time_in_seconds: int):
+        output_validator = NumFileRangeValidator(min_files, max_files)
+        
output_validator.set_output_dir(self.file_system_observer.get_output_dir())
+        self.__check_output_over_time_period(wait_time_in_seconds, 
output_validator)

Review Comment:
   Updated in 41364556e36680ca7f8d564ffa08fe110188a34c



##########
extensions/http-curl/processors/InvokeHTTP.cpp:
##########
@@ -115,6 +115,8 @@ void InvokeHTTP::setupMembersFromProperties(const 
core::ProcessContext& context)
 
   use_chunked_encoding_ = (context.getProperty(UseChunkedEncoding) | 
utils::andThen(&utils::StringUtils::toBool)).value_or(false);
   send_date_header_ = context.getProperty<bool>(DateHeader).value_or(true);
+  context.getProperty(UploadSpeedLimit, maximum_upload_speed_);
+  context.getProperty(DownloadSpeedLimit, maximum_download_speed_);

Review Comment:
   Good catch, updated in 41364556e36680ca7f8d564ffa08fe110188a34c



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to