ChrisSamo632 commented on code in PR #7868:
URL: https://github.com/apache/nifi/pull/7868#discussion_r1355627921
##########
nifi-nar-bundles/nifi-graph-bundle/nifi-other-graph-services/src/main/java/org/apache/nifi/graph/TinkerpopClientService.java:
##########
@@ -167,6 +167,7 @@ public class TinkerpopClientService extends
AbstractControllerService implements
" Note: when using a remote.yaml file, this username value
(if set) will overload any " +
"username set in the YAML file.")
.required(false)
+ .addValidator(Validator.VALID)
Review Comment:
Seems like `StandardValidators.ATTRIBUTE_EXPRESSION_LANGUAGE_VALIDATOR` or
`StandardValidators.NON_EMPTY_VALIDATOR` would be better for these properties -
this allows them to remain optional, but prevents empty values being set, which
is probably not valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
