ChrisSamo632 commented on code in PR #7880:
URL: https://github.com/apache/nifi/pull/7880#discussion_r1359399578
##########
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/toolkit/tls/TlsToolkitMain.java:
##########
@@ -86,6 +86,8 @@ protected Method getMain(String service) {
printUsageAndExit("Unknown service: " + service,
ExitCode.INVALID_ARGS);
}
+ System.out.println("The TLS Toolkit is deprecated and targeted for
removal in Apache NiFi 2.0.");
Review Comment:
Can/should we use the Deprecation Logger here?
And consider adding the `@Deprecated` annotation for `public`
classes/methods referenced elsewhere so people get more warnings about this
utility being removed in the future. The simple `System.out` could be easily
missed (but I've not checked whether the standard NiFi Deprecation Logger would
be available for us easily here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
