szaszm commented on code in PR #1681:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1362202851
##########
CMakeLists.txt:
##########
@@ -269,13 +260,12 @@ add_library(ut INTERFACE)
target_include_directories(ut SYSTEM INTERFACE
"${CMAKE_CURRENT_SOURCE_DIR}/thirdparty/ut")
# cURL
-if(NOT DISABLE_CURL)
+if(ENABLE_CURL)
Review Comment:
It doesn't strictly belong here, but I wouldn't be against hardcoding these
to true. The usability of minifi is very limited without curl and openssl.
##########
.gitignore:
##########
@@ -48,6 +48,7 @@ cmake-build-debug
*flowfile_checkpoint
build
/*build*
+!win_build_vs.bat
Review Comment:
Is there another rule that matches `win_build_vs.bat` that makes this
exclusion necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
