Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/64#discussion_r92008401
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/RemoteProcessGroupSchema.java
---
@@ -78,9 +80,14 @@ public RemoteProcessGroupSchema(Map map) {
yieldPeriod = getOptionalKeyAsType(map, YIELD_PERIOD_KEY,
String.class, wrapperName, DEFAULT_YIELD_PERIOD);
transportProtocol = getOptionalKeyAsType(map,
TRANSPORT_PROTOCOL_KEY, String.class, wrapperName, DEFAULT_TRANSPORT_PROTOCOL);
- if (!transportProtocolOptions.valid(transportProtocol)){
+ if (!TransportProtocolOptions.valid(transportProtocol)){
addValidationIssue(TRANSPORT_PROTOCOL_KEY, wrapperName, "it
must be either 'RAW' or 'HTTP' but is '" + transportProtocol + "'");
}
+
+ proxyHost = getOptionalKeyAsType(map, PROXY_HOST_KEY,
String.class, wrapperName, DEFAULT_PROXY_HOST);
--- End diff --
I believe we should add some more validation checks here. Such as if the
host or port is set then the other must be. Also if username is set then
password is set. Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
