[
https://issues.apache.org/jira/browse/NIFI-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743080#comment-15743080
]
ASF GitHub Bot commented on NIFI-3170:
--------------------------------------
GitHub user scottyaslan opened a pull request:
https://github.com/apache/nifi/pull/1322
[NIFI-3170] remove action details if user does not have read perms, a…
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
…lso update action details styles to match other dialogs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scottyaslan/nifi NIFI-3170
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1322
----
commit 0bde7dfe36396e5bbde6d215e40c3f93ddabb887
Author: Scott Aslan <[email protected]>
Date: 2016-12-12T20:36:05Z
[NIFI-3170] remove action details if user does not have read perms, also
update action details styles to match other dialogs
----
> UI - Unauthorized action in Flow Configuration History
> ------------------------------------------------------
>
> Key: NIFI-3170
> URL: https://issues.apache.org/jira/browse/NIFI-3170
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core UI
> Reporter: Matt Gilman
> Assignee: Scott Aslan
> Priority: Trivial
> Fix For: 1.2.0
>
>
> When a user does not have permissions to an action in the flow configuration
> history, we should not be rendering the more info icon. Currently, if you
> attempt to click the more info icon there is a javascript error since the
> additional details are not returned to the client.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
