szaszm commented on code in PR #1680: URL: https://github.com/apache/nifi-minifi-cpp/pull/1680#discussion_r1367522637
########## CPPLINT.cfg: ########## @@ -1,2 +1,2 @@ set noparent -filter=-runtime/reference,-runtime/string,-build/c++11,-build/include_subdir,-whitespace/forcolon,-build/namespaces_literals,-readability/check,-build/include_what_you_use,-readability/nolint +filter=-runtime/reference,-runtime/string,-build/c++11,-build/include_subdir,-whitespace/forcolon,-build/namespaces_literals,-readability/check,-build/include_what_you_use,-readability/nolint,-readability/braces Review Comment: To be honest, I have the feeling that we would be better off by dropping cpplint, and rely more on clang-tidy, especially as you recent changes in #1671 get ready and do the google-specific checks. Too many false positives, and it looks outdated barely maintained. On the other hand, it runs much faster than clang-tidy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
