[
https://issues.apache.org/jira/browse/NIFI-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15744236#comment-15744236
]
ASF GitHub Bot commented on NIFI-3166:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/1324
NIFI-3166: Fix SocketRemoteSiteListener NPE.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
- Refactored ServerProtocol.sendPeerList method signature to clarify the
meaning of arguments, and avoid null pointer exception when converting
null Integer to int.
- Refactored SocketRemoteSiteListener handleRequest method to make it
more unit test friendly.
- Added more unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-3166
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1324.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1324
----
commit 4288517886f6a54ac2e2c5311556aec7e33bc1fd
Author: Koji Kawamura <[email protected]>
Date: 2016-12-13T05:33:16Z
NIFI-3166: Fix SocketRemoteSiteListener NPE.
- Refactored ServerProtocol.sendPeerList method signature to clarify the
meaning of arguments, and avoid null pointer exception when converting
null Integer to int.
- Refactored SocketRemoteSiteListener handleRequest method to make it
more unit test friendly.
- Added more unit tests.
----
> SocketRemoteSiteListener NPE when calling
> NifiProperties.getRemoteInputHttpPort
> -------------------------------------------------------------------------------
>
> Key: NIFI-3166
> URL: https://issues.apache.org/jira/browse/NIFI-3166
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.1.0
> Reporter: Andre
> Assignee: Koji Kawamura
>
> When using the following properties:
> nifi.remote.input.host=node1.textbed.internal
> nifi.remote.input.secure=true
> nifi.remote.input.socket.port=54321
> nifi.remote.input.http.enabled=false
> nifi.remote.input.http.transaction.ttl=30 sec
> I hit
> {code}
> 2016-12-09 00:15:26,456 ERROR [Site-to-Site Worker Thread-145]
> o.a.nifi.remote.SocketRemoteSiteListener
> java.lang.NullPointerException: null
> at
> org.apache.nifi.remote.SocketRemoteSiteListener$1$1.run(SocketRemoteSiteListener.java:280)
> ~[nifi-site-to-site-1.1.0.jar:1.1.0]
> at java.lang.Thread.run(Thread.java:745) [na:1.8.0_101]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
