rfellows commented on code in PR #7924:
URL: https://github.com/apache/nifi/pull/7924#discussion_r1372102017
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/policy-management.jsp:
##########
@@ -44,16 +44,6 @@
</div>
<div class="clear"></div>
</div>
- <div id="policy-selected-template-container" class="hidden
policy-selected-component-container">
- <div class="policy-selected-component-type-icon">
- <i class="icon icon-template"></i>
- </div>
- <div class="policy-selected-component-details-container">
- <div class="policy-selected-component-name"></div>
- <div class="policy-selected-component-type">Template</div>
- </div>
- <div class="clear"></div>
- </div>
Review Comment:
I don't believe that this policy template has anything to do with flow
templates. We should put this back.
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-policy-management.js:
##########
@@ -1611,60 +1611,6 @@
return loadPolicy().always(showPolicy);
},
- /**
- * Shows the template policy.
- *
- * @param d
- */
- showTemplatePolicy: function (d) {
- initializingComponentPolicy = true;
-
- // reset the policy message
- resetPolicyMessage();
-
- // update the policy controls visibility
- $('#component-policy-controls').show();
- $('#global-policy-controls').hide();
-
- // update the visibility
- if (d.permissions.canRead === true) {
- $('#policy-selected-template-container
div.policy-selected-component-name').text(d.template.name);
- } else {
- $('#policy-selected-template-container
div.policy-selected-component-name').text(d.id);
- }
- $('#policy-selected-template-container').show();
-
- // populate the initial resource
- $('#selected-policy-component-id').text(d.id);
- $('#selected-policy-component-type').text('templates');
- $('#component-policy-target')
- .combo('setOptionEnabled', {
- value: 'operate-component'
- }, false)
- .combo('setOptionEnabled', {
- value: 'write-receive-data'
- }, false)
- .combo('setOptionEnabled', {
- value: 'write-send-data'
- }, false)
- .combo('setOptionEnabled', {
- value: 'read-data'
- }, false)
- .combo('setOptionEnabled', {
- value: 'read-provenance'
- }, false)
- .combo('setOptionEnabled', {
- value: 'write-data'
- }, false)
- .combo('setSelectedOption', {
- value: 'read-component'
- });
-
- initializingComponentPolicy = false;
-
- return loadPolicy().always(showPolicy);
- },
-
Review Comment:
I don't think we should remove this. This isn't the same kind of template
that we are trying to remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
