ChrisSamo632 commented on code in PR #7931: URL: https://github.com/apache/nifi/pull/7931#discussion_r1372121807
########## nifi-commons/nifi-security-cert/src/main/java/org/apache/nifi/security/cert/StandardPrincipalFormatter.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.security.cert; + +import javax.security.auth.x500.X500Principal; +import java.security.cert.X509Certificate; +import java.util.Objects; + +/** + * Standard Principal Formatter implementation returns Subject and Issuer formatted according to RFC 1779 following the convention of getSubjectDN and getIssuerDN methods + */ +public class StandardPrincipalFormatter implements PrincipalFormatter { + private static final PrincipalFormatter INSTANCE = new StandardPrincipalFormatter(); + + private StandardPrincipalFormatter() { + + } + + /** + * Get singleton instance of Principal Formatter + * + * @return Standard Principal Formatter + */ + public static PrincipalFormatter getInstance() { + return INSTANCE; + } + + /** + * Get Subject Distinguished Name formatted as a string according to RFC 1779 with spaces between elements + * + * @param certificate X.509 Certificate + * @return Subject Distinguished Name formatted according to RFC 1779 + */ + @Override + public String getSubject(final X509Certificate certificate) { + Objects.requireNonNull(certificate, "Certificate required"); + return getFormatted(certificate.getSubjectX500Principal()); + } + + /** + * Get Issuer Distinguished Name formatted as a string according to RFC 1779 with spaces between elements + * + * @param certificate X.509 Certificate + * @return Issuer Distinguished Name formatted according to RFC 1779 + */ + @Override + public String getIssuer(final X509Certificate certificate) { + Objects.requireNonNull(certificate, "Certificate required"); + return getFormatted(certificate.getIssuerX500Principal()); + } + + private String getFormatted(final X500Principal principal) { + return principal.getName(X500Principal.RFC1779); Review Comment: Do you foresee a need for other formats in the future, e.g. `RFC2253`? If so, should we make the format configurable for the client? If there's no apparent need right now (I can't see an immediate one if the LDAP connectivity wouldn't benefit from the new formatter/approach), then happy for this to be something that can be added later if/when the need arises -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
