NissimShiman commented on PR #7781: URL: https://github.com/apache/nifi/pull/7781#issuecomment-1783230528
Rebased and resolved the minor points. Regarding `migrateProperties(PropertyConfiguration config)`, I looked more into this and currently the behaviour of `PropertyConfiguration`'s [hasProperty()](https://github.com/apache/nifi/blob/main/nifi-api/src/main/java/org/apache/nifi/migration/PropertyConfiguration.java#L79) is to return true on any property found in 2.x (and any property found in 1.x that is not in 2.x that was brought over in a migration) So it always returns true when checking if `CONFIG_STRATEGY` is new (so the potential code in the previous comment won't work for us here). (That being said, it can have its uses when a property from 1.x is no longer found in 2.x. If it returns true then we can call `config.removeProperty()`, so that is perhaps an alternate way for dealing with deprecated properties, but this is not applicable here.) So it doesn't seem `migrateProperties()` has a solution for the use case of this ticket/PR. (or at least not yet) I'm not sure of the way forward here. Maybe this could this just be noted in migration guidance (i.e. that `CONFIG_STRATEGY` will be `PRESET` after migration)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
