exceptionfactory commented on code in PR #7922:
URL: https://github.com/apache/nifi/pull/7922#discussion_r1379057623
##########
nifi-nar-bundles/nifi-jslt-bundle/nifi-jslt-processors/src/main/java/org/apache/nifi/processors/jslt/JSLTTransformJSON.java:
##########
@@ -107,6 +108,16 @@ public class JSLTTransformJSON extends AbstractProcessor {
.defaultValue(EACH_OBJECT.getValue())
.build();
+ public static final PropertyDescriptor RESULT_FILTER = new
PropertyDescriptor.Builder()
+ .name("jslt-transform-result-filter")
+ .displayName("Transform Result Filter")
+ .description("An optional filter of output results using another
JSLT, allowing you to change the default filter."
+ + " The default filter is \". != null and . != {} and . !=
[]\" which excludes objects with null values, empty objects and empty arrays")
Review Comment:
Instead of making this an optional property, what do you think about setting
it as required and providing the default value? This would make the default
behavior more obvious, and provide a quick example of what it can do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
