krisztina-zsihovszki commented on code in PR #8004:
URL: https://github.com/apache/nifi/pull/8004#discussion_r1389380252
##########
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/PutKudu.java:
##########
@@ -165,7 +165,7 @@ public class PutKudu extends AbstractKuduProcessor {
.name("Operation RecordPath")
.displayName("Operation RecordPath")
.description("If specified, this property denotes a RecordPath that
will be evaluated against each incoming Record in order to determine the Kudu
Operation Type. When evaluated, the " +
- "RecordPath must evaluate to one of hte valid Kudu Operation
Types, or the incoming FlowFile will be routed to failure. If this property is
specified, the <Kudu Operation Type> property" +
+ "RecordPath must evaluate to one of the valid Kudu Operation
Types, or the incoming FlowFile will be routed to failure. If this property is
specified, the <Kudu Operation Type> property" +
Review Comment:
In my view it would worth mentioning in the parameter description or even in
Additional Details that the Debezium operations (r, i,d,u) are supported and
mapped to the PutKudu "standard" operations (INSERT, UPDATE etc.) otherwise
users won't know about this improvement.
##########
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/PutKudu.java:
##########
@@ -688,7 +688,16 @@ public OperationType apply(final Record record) {
final String resultValue =
String.valueOf(resultList.get(0).getValue());
try {
- return OperationType.valueOf(resultValue.toUpperCase());
+ switch (resultValue) {
Review Comment:
Please include the operation "r" (read) which is also interpreted as insert.
Debezium sends a read event for the rows already existed in database when
Debezium engine started.
The records inserted to DB after Debezium has been started are captured as
"c" (create) events.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
