pvillard31 commented on code in PR #7465:
URL: https://github.com/apache/nifi/pull/7465#discussion_r1389508554
##########
minifi/minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-resources/src/main/resources/conf/logback.xml:
##########
@@ -29,12 +29,14 @@
To ZIP rolled files, replace '.log' with '.log.zip'.
-->
<fileNamePattern>${org.apache.nifi.minifi.bootstrap.config.log.dir}/${org.apache.nifi.minifi.bootstrap.config.log.app.file.name}_%d{yyyy-MM-dd_HH}.%i.${org.apache.nifi.minifi.bootstrap.config.log.app.file.extension}.gz</fileNamePattern>
- <!-- Keep 10 rolling periods worth of log files-->
- <maxHistory>10</maxHistory>
- <!-- Max size each log file will be-->
+ <!-- Control the maximum size of each log file before rolling over
-->
<maxFileSize>1MB</maxFileSize>
- <!-- Provide a cap of 10 MB across all archive files -->
+ <!-- Control the maximum number of log archive files kept and
asynchronously delete older files -->
+ <maxHistory>10</maxHistory>
+ <!-- Control the total size of all log archive files for this
appender -->
<totalSizeCap>10MB</totalSizeCap>
+ <!-- Log files exceeding maximum settings will be rolled on
startup -->
+ <cleanHistoryOnStart>true</cleanHistoryOnStart>
Review Comment:
While we're making changes in this file, I'd be in favor for increasing 1MB
to 10MB and 10MB to 100MB as the current values seem a bit small to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
