exceptionfactory commented on code in PR #7923:
URL: https://github.com/apache/nifi/pull/7923#discussion_r1389979502
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/cluster/nf-cluster-table.js:
##########
@@ -813,7 +813,7 @@
function sort(sortDetails, dataView, tab) {
// defines a function for sorting
var comparer = function (a, b) {
- if (sortDetails.columnId === 'heartbeat' || sortDetails.columnId
=== 'uptime') {
+ if (sortDetails.columnId === 'heartbeat' || sortDetails.columnId
=== 'nodeStartTime') {
Review Comment:
This change to `nodeStartTime` appears to be incorrect since `nodeStartTime`
is a `field` value not an `id` value. Should that part of the conditional be
removed since the `uptime` ID is being compared later on using the duration
comparison?
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/cluster/nf-cluster-table.js:
##########
@@ -853,6 +852,14 @@
var aNode = formatNodeAddress(a);
var bNode = formatNodeAddress(b);
return aNode === bNode ? 0 : aNode > bNode ? 1 : -1;
+ } else if (sortDetails.columnId === 'version' ||
sortDetails.columnId === 'javaVersion') {
Review Comment:
The field `id` is `javaversion` all lowercase, versus the `field` value,
which is `javaVersion`, so it looks like this needs to be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
