szaszm commented on code in PR #1693:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1693#discussion_r1394504470
##########
extensions/http-curl/processors/InvokeHTTP.cpp:
##########
Review Comment:
Same here: flow file attributes are no longer usable in the expression
language. While InvokeHTTP doesn't document any EL support, I'd rather not
break behavior, and possibly document the properties that actually support EL
with flow file context.
##########
extensions/splunk/PutSplunkHTTP.cpp:
##########
Review Comment:
The changes to this processor kill EL support: referencing flow file
attributes is no longer possible if we evaluate the changed properties in
`onSchedule`. I'd prefer to keep the old behavior.
##########
extensions/standard-processors/processors/ListenTCP.h:
##########
@@ -86,7 +86,7 @@ class ListenTCP : public NetworkListenerProcessor {
EXTENSIONAPI static constexpr auto OutputAttributes =
std::array<core::OutputAttributeReference, 2>{PortOutputAttribute, Sender};
void initialize() override;
- void onSchedule(const std::shared_ptr<core::ProcessContext>& context, const
std::shared_ptr<core::ProcessSessionFactory>& sessionFactory) override;
+ void onSchedule(core::ProcessContext& context, core::ProcessSessionFactory&
session_Factory) override;
Review Comment:
```suggestion
void onSchedule(core::ProcessContext& context,
core::ProcessSessionFactory& sessionFactory) override;
```
or
```suggestion
void onSchedule(core::ProcessContext& context,
core::ProcessSessionFactory& session_factory) override;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
