lordgamez commented on code in PR #1696:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1696#discussion_r1397441922
##########
.github/workflows/ci.yml:
##########
@@ -111,7 +111,7 @@ jobs:
- name: build
run: |
for /f "usebackq delims=" %%i in (`vswhere.exe -latest -property
installationPath`) do if exist "%%i\Common7\Tools\vsdevcmd.bat" call
"%%i\Common7\Tools\vsdevcmd.bat" -arch=x64 -host_arch=x64
- win_build_vs.bat ..\b /64 /CI /S /A /PDH /SPLUNK /GCP /ELASTIC /K /L
/R /Z /N /RO /PR /PYTHON_SCRIPTING /LUA_SCRIPTING /MQTT /SCCACHE /NINJA
+ win_build_vs.bat ..\b /64 /CI /PDH /R /N /RO /SCCACHE /NINJA
Review Comment:
Yes, the removed options do not exist anymore, they are enabled by default
and there is a `NO_*` option for those, so they are not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
