mcgilman commented on PR #8075:
URL: https://github.com/apache/nifi/pull/8075#issuecomment-1832650893

   > Per our offline discussion about moving the Controller Service listing out 
of the Process Group configuration dialog... I think we can now update the 
logic in `canvat-utils.service.ts#isConfigurable` to not blindly allow the pg 
configuration screen to be opened. Not positive and correct me if I'm wrong, 
but I suspect the original intent here was that we couldn't prevent the user 
from seeing the controller services of a process group if the user didn't have 
read access to the PG itself. Now that we plan to have a different dialog for 
this, we don't need to support a read-only mode for the pg configuration.
   
   This is correct. Previously users could have access to Services within the 
Process Group but not the Process Group itself. By pulling the service listing 
into its own page we no longer need to _always_ support configuring the Process 
Group. I'll update the `CanvasUtils` accordingly.
   
   This PR does not currently allow the user to configure the current Process 
Group. I'll update this PR to guard against this case so there are no errors 
but actually supporting configuring the current Process Group will come in a 
follow-up effort. I've already begun creating the service listing and 
introducing a new route for configuring the current Process Group would 
conflict with those changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to