adamdebreceni commented on code in PR #1640:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1640#discussion_r1412074613
##########
libminifi/include/core/ContentSession.h:
##########
@@ -39,6 +52,12 @@ class ContentSession {
virtual void rollback() = 0;
virtual ~ContentSession() = default;
+
+ protected:
+ virtual std::shared_ptr<io::BaseStream> append(const
std::shared_ptr<ResourceClaim>& resource_id) = 0;
+
+ std::map<std::shared_ptr<ResourceClaim>, ExtensionData> extensions_;
Review Comment:
it contains extra data for resources that have been appended to, should we
rename it to something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
