exceptionfactory commented on code in PR #8120:
URL: https://github.com/apache/nifi/pull/8120#discussion_r1414545297
##########
nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/processors/slack/PostSlack.java:
##########
@@ -82,6 +83,14 @@
" The property name will not be used by the processor.",
expressionLanguageScope = ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
@WritesAttribute(attribute="slack.file.url", description = "The Slack URL of
the uploaded file. It will be added if 'Upload FlowFile' has been set to
'Yes'.")
+@DeprecationNotice(
+ alternatives = {PublishSlack.class},
+ reason = "This Processor is more difficult to configure than necessary,
and exposes intricate nuances of the Slack API that need not be exposed. " +
+ "Additionally, it lacks some capabilities, such as responding to
messages in threads. It interacts directly with the Slack API instead of " +
+ "making use of the Slack-provided SDK, which makes the Processor
much more brittle. Additionally, it does not make clear the differences " +
+ "between PutSlack and PostSlack. Each provides slightly different
capabilities. " +
+ "PublishSlack combines the capabilities of both Processors in a
simpler configuration that makes use of Slack's standard REST API."
+)
Review Comment:
Rather than tag this on deprecated on the main branch, the deprecation
should be added on the support branch. The removal of these Processors could be
handled in this pull request, or in a subsequent PR.
##########
nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/pom.xml:
##########
@@ -61,10 +61,6 @@
<groupId>org.slf4j</groupId>
<artifactId>jcl-over-slf4j</artifactId>
</dependency>
- <dependency>
- <groupId>org.apache.nifi</groupId>
- <artifactId>nifi-api</artifactId>
- </dependency>
Review Comment:
It seems like this should still be declared, perhaps the removal triggered
the other addition with the compile scope, but this one looks correct.
##########
nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/processors/slack/PutSlack.java:
##########
@@ -66,6 +67,13 @@
@DynamicProperty(name = "A JSON object to add to Slack's \"attachments\" JSON
payload.", value = "JSON-formatted string to add to Slack's payload JSON
appended to the \"attachments\" JSON array.",
expressionLanguageScope = ExpressionLanguageScope.FLOWFILE_ATTRIBUTES,
description = "Converts the contents of each value specified by the
Dynamic Property's value to JSON and appends it to the payload being sent to
Slack.")
+@DeprecationNotice(
Review Comment:
Same as noted on `PostSlack`, the deprecation should be removed and applied
to the support branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
