exceptionfactory commented on code in PR #8101:
URL: https://github.com/apache/nifi/pull/8101#discussion_r1418010127
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/NarClassLoaders.java:
##########
@@ -74,6 +74,7 @@ private InitContext(
this.jettyBundle = jettyBundle;
this.serverInstance = serverInstance;
this.bundles = bundles;
+ System.setProperty("nifi.version",
frameworkBundle.getBundleDetails().getCoordinate().getVersion());
Review Comment:
Recommend adding a comment indicating the reason for this addition. I would
recommend naming this `framework.version` to avoid potential confusion that
could result from different NAR extension versions, which are also part of
NiFi, but could be different in particular installations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
