martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1424034289
########## bootstrap/system_dependency.py: ########## @@ -0,0 +1,55 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from __future__ import annotations + +from typing import Dict, Set + +from minifi_option import MinifiOptions +from package_manager import PackageManager + + +def _create_system_dependencies(minifi_options: MinifiOptions) -> Dict[str, Set[str]]: + system_dependencies = {'patch': {'patch'}, 'make': {'make'}} + if minifi_options.is_enabled("ENABLE_EXPRESSION_LANGUAGE"): + system_dependencies['bison'] = {'bison'} + system_dependencies['flex'] = {'flex'} + if minifi_options.is_enabled("ENABLE_LIBARCHIVE"): + system_dependencies['libarchive'] = {'libarchive'} + if minifi_options.is_enabled("ENABLE_PCAP"): + system_dependencies['libpcap'] = {'libpcap'} + if minifi_options.is_enabled("ENABLE_USB_CAMERA"): + system_dependencies['libusb'] = {'libusb'} + system_dependencies['libpng'] = {'libpng'} + if minifi_options.is_enabled("ENABLE_GPS"): + system_dependencies['gpsd'] = {'gpsd'} + if minifi_options.is_enabled("ENABLE_COAP"): + system_dependencies['automake'] = {'automake'} + system_dependencies['autoconf'] = {'autoconf'} + system_dependencies['libtool'] = {'libtool'} + if minifi_options.is_enabled("ENABLE_LUA_SCRIPTING"): + system_dependencies['lua'] = {'lua'} + if minifi_options.is_enabled("ENABLE_PYTHON_SCRIPTING"): + system_dependencies['python'] = {'python'} + if minifi_options.is_enabled("MINIFI_OPENSSL"): + system_dependencies['openssl'] = {'perl'} Review Comment: Thats packaged with strawberryperl, (with the whole toolchain but that causes other problems). Usually we wipe the c:\Strawberry\c\bin dir to fix those problems, but then we also wipe the NASM which is required, so we had to install that aswell, instead Im deleting the installed toolchain but leave NASM alone. https://github.com/martinzink/nifi-minifi-cpp/blob/python_bootstrap/bootstrap/package_manager.py#L178 (installing NASM separatly came with its own issues, since neither choco nor winget sets the PATH for NASM) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
