szaszm commented on code in PR #1709:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1709#discussion_r1426258158
##########
CMakeLists.txt:
##########
@@ -422,8 +422,12 @@ if(WIN32)
file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/conf/" DESTINATION
"${CMAKE_CURRENT_BINARY_DIR}/conf/")
file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/LICENSE" DESTINATION
"${CMAKE_CURRENT_BINARY_DIR}")
- file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/README.md" DESTINATION
"${CMAKE_CURRENT_BINARY_DIR}")
+ #file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/README.md" DESTINATION
"${CMAKE_CURRENT_BINARY_DIR}")
Review Comment:
I guess the thinking behind this was that if this is ever changed, the
README needs special handling. But I can certainly just remove the line, I
don't really have a strong argument against it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
