martinzink commented on PR #79: URL: https://github.com/apache/nifi-site/pull/79#issuecomment-1860945190
> > > Thanks for making the updates @martinzink. > > > Looking at the latest version, I think it would be better to introducing the new about pages and simply have two separate sections on the main MiNiFi page, one paragraph for Java, and one for CPP. > > > > > > Not sure if I follow you here. :/ Should I remove the MiNiFi Java, MiNiFi C++ dropdowns and include those links in their about md. Which I should simple embed in the landing page? > > Thanks for the reply, sorry for the confusion. > > On further review, I see that the two about pages for Java and C++ are pulled in through an include to the main index.md. Although that content could be moved to the `partials` directory and then included, it seems like it would be best to simple copy the content from the about files into the index.md directly, avoiding the need for separate files. Is there some other reason for having that content in separate files, as opposed to just having it written directly in the index.md? The reason I went with this convoluted way is that I wanted to create a proper up-to-date starting guide/landing page separately for java and c++ aswell and it would have made sense to include these small summaries there aswell. After a little bit of time I felt that those pages are a bit out of the scope of this PR and wanna do them in a followup PR (maybe after the redesign?). But I agree its unneccessary complication for now, so I've removed these in https://github.com/apache/nifi-site/pull/79/commits/30521e9046501bb4ee55e36578343b47a92457b6 and I'll cross this bridge when I come to it :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
