rfellows commented on code in PR #8173:
URL: https://github.com/apache/nifi/pull/8173#discussion_r1434124896
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/provenance/ui/provenance-event-listing/provenance-event-table/provenance-event-table.component.html:
##########
@@ -18,7 +18,9 @@
<div class="provenance-event-table h-full">
<div [class.hidden]="showLineage" class="h-full flex flex-col gap-y-2">
<div class="flex flex-col">
- <div class="value font-bold">Displaying {{ filteredCount }} of {{
totalCount }}</div>
+ <div [class.invisible]="!filterApplied" class="value font-bold">
+ Displaying {{ filteredCount }} of {{ totalCount }}
Review Comment:
This is still not very intuitive IMO. Maybe something like
"Filter matched {{filterCount}} of {{totalCount}}"
Since we still aren't displaying all of the matches if they span more than 1
page.
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/provenance/ui/provenance-event-listing/provenance-event-table/lineage/lineage.component.ts:
##########
@@ -46,11 +46,13 @@ export class LineageComponent implements OnInit {
this.addLineage(lineage.results.nodes, lineage.results.links);
}
}
+
@Input() eventId: string | null = null;
+
@Input() set eventTimestampThreshold(eventTimestampThreshold: number) {
if (this.previousEventTimestampThreshold >= 0) {
- let nodes: any = this.lineageContainerElement.selectAll('g.node');
- let links: any =
this.lineageContainerElement.selectAll('path.link');
+ let nodes: any =
this.lineageContainerElement.selectAll('g.node.rendered');
+ let links: any =
this.lineageContainerElement.selectAll('path.link.rendered');
Review Comment:
when showing/hiding these items we should also turn on/of pointer-events.
Otherwise, you can still get to the context menus for the hidden items if you
mouse over them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
