markap14 commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1434525927
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml:
##########
@@ -468,6 +468,11 @@
<groupId>org.glassfish.jaxb</groupId>
<artifactId>jaxb-runtime</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-data-provenance-utils</artifactId>
+ <version>2.0.0-SNAPSHOT</version>
+ </dependency>
Review Comment:
We should probably eliminate this newly introduced `UploadContext`. While it
does keep the `ProvenanceReporter` cleaner by avoiding introducing several
potential overrides, it introduces more complexity into the Processors that
might want to call the method. I.e., the overrides make the ProvenanceReporter
more complex but make the Processors simpler. This is one of those situations
where I could go either way. But the fact that interface already is laid out to
use several overrides means it's cleaner to keep consistent. Additionally, it
eliminates the need for something like this in data-provenance-utils and also
avoids introducing something like this into the nifi-api
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
